Changeset - c20abcf4adb9
[Not reviewed]
default
0 1 0
Thomas De Schampheleire (patrickdp) - 8 years ago 2017-07-05 19:08:17
thomas.de.schampheleire@gmail.com
tests: fix failures due to environment LANG settings (Issue #286)

When the environment in which the tests are run dictates a non-English
language (e.g. via LANG=de_DE.UTF-8), certain tests started to fail because
formencode validation messages where translated in that language.

A test failing this way is for example
test_create_in_group_without_needed_permissions in
kallithea/tests/functional/test_admin_repos.py .

This is a regression of commit 3b29103657df (i18n: remove explicit
formencode language setting), but in fact reverting it is not the right
solution as there is no problem except during test execution.

Instead, force the formencode language to 'empty' (meaning English) for test
execution only.

See also http://www.formencode.org/en/latest/i18n.html
1 file changed with 3 insertions and 0 deletions:
0 comments (0 inline, 0 general) First comment
kallithea/tests/conftest.py
Show inline comments
 
@@ -4,6 +4,7 @@ import logging
 
import pkg_resources
 
import time
 

	
 
import formencode
 
from paste.deploy import loadwsgi
 
from routes.util import URLGenerator
 
import pytest
 
@@ -57,6 +58,8 @@ def pytest_configure():
 

	
 
    kallithea.tests.base.url = URLGenerator(RootController().mapper, {'HTTP_HOST': 'example.com'})
 

	
 
    # set fixed language for form messages, regardless of environment settings
 
    formencode.api.set_stdtranslation(languages=[])
 

	
 
@pytest.fixture
 
def create_test_user():
0 comments (0 inline, 0 general) First comment
You need to be logged in to comment. Login now