kallithea-incoming Changeset - dee1b60bad29

Changeset - dee1b60bad29

Parent rev.

Child rev.

[Not reviewed]

stable

0 1 0

Mads Kiilerich (kiilerix) - 23 months ago 2023-05-07 16:19:38
mads@kiilerich.com

auth: the owner should have admin access when computing repo group permissions

When computing repo group permissions in repository_group_permissions(), always
give admin permissions to the group owner.

That is similar to how repository_permissions() gives admin permissions to the
repo owner.

The extra computation shouldn't cause any extra database hits or make the
computation more complex or expensive, so that should be fine.

1 file changed with 4 insertions and 1 deletions:

kallithea/lib/auth.py

0 comments (0 inline, 0 general) First comment

kallithea/lib/auth.py

➞

Show inline comments

@@ @@ -262,7 +262,10 @@ class AuthUser(object): @@
             # on given group
             for perm in default_repo_groups_perms:
                 rg_k = perm.group.group_name
                 p = perm.permission.permission_name
                 if perm.group.owner_id == self.user_id:
                     p = 'group.admin'
                 else:
                     p = perm.permission.permission_name
                 repository_group_permissions[rg_k] = p
             # user group for repo groups permissions

0 comments (0 inline, 0 general) First comment