Issue #84: compare revisions: in-line comment icon appears but is not clickable
Reported by: | Thomas De Schampheleire |
State: | resolved |
Created on: | 2015-01-23 14:12 |
Updated on: | 2015-08-06 20:25 |
Description
When comparing two revisions and hovering a code line, the comment icon appears but nothing happens when you click it.
Either we should not show the icon, and thus disallow comments from a compare view, or the icon should be clickable and a comment box should appear.
Attachments
Comments
Comment by Mads Kiilerich, on 2015-01-23 18:19
Can you give a link to an example, perhaps on https://kallithea-scm.org/repos/kallithea ?
Comment by Thomas De Schampheleire, on 2015-01-23 18:28
Sure, see https://kallithea-scm.org/repos/kallithea/compare/tag@v1.7.2...tag@v1.7.1?other_repo=kallithea and try to add any in-line comment.
Comment by Thomas De Schampheleire, on 2015-08-06 20:25
Fixed with commit 329c0584cba8