Kallithea issues archive

Issue #79: pull requests: commit overview should preserve newlines in commit msgs

Reported by: Thomas De Schampheleire
State: resolved
Created on: 2015-01-23 12:30
Updated on: 2015-02-18 23:18


On a pull request, in block 'Summary of Pull Request Content', the commit messages are not displayed verbatim. For example, blank lines are removed. I expect any formatting of the commit message (newlines, indentation) to be preserved.



Comment by Mads Kiilerich, on 2015-01-23 18:09

IIRC, they are interpreted as RST or MD by default.

I dislike that very much. Commit messages and review comments are for quick and efficient information exchange between technical people. All time spent on layout is wasted time ... especially when some magic interpretation of code snippets are obfuscated by interpretation as markup.

I am using a patch that disables all this magic and just makes it cleartext. It is currently a bit of a hack because of some layering violations. I would like to just drop the markup code, but could perhaps compromise on makign it configurable somehow ;-)

Somewhat related: there is an issue regarding html markup in text emails.

Comment by Jan Heylen, on 2015-01-24 13:46

@kiilerix is this patch you mention available somewhere?

Comment by Mads Kiilerich, on 2015-01-24 15:16

Comment by Thomas De Schampheleire, on 2015-02-09 21:37

Comment by Mads Kiilerich, on 2015-02-18 23:18

thanks for the patch