Kallithea issues archive

Issue #6: RC_SCM_DATA renamed KALLITHEA_EXTRAS for hooks

Reported by: moparisthebest
State: resolved
Created on: 2014-07-09 17:38
Updated on: 2014-07-14 19:24

Description

And it's not documented anywhere, I see 3 options here:

  1. leave code alone, document change
  2. set both
  3. revert change, just set RC_SCM_DATA not KALLITHEA_EXTRAS

I also don't mind doing the actual work and putting in a pull request, it's trivial, just don't know which you prefer.

Attachments

hooks.diff

Comments

Comment by Mads Kiilerich, on 2014-07-09 18:06

I suggest setting both, document the change, and at the same time also keep RC_SCM_DATA "undocumented"/deprecated (but I guess we will keep it around forever).

Comment by moparisthebest, on 2014-07-09 19:05

It's a super small patch, if you'd prefer a pull request instead, just let me know.

Comment by Mads Kiilerich, on 2014-07-14 19:24

Comment by Mads Kiilerich, on 2014-07-14 19:24