Issue #50: Show more context when clicking "three dots" links in pull requests
| Reported by: | Anatoly Belikov |
| State: | new |
| Created on: | 2014-10-21 14:48 |
| Updated on: | 2015-08-06 19:45 |
Description
In a pull request view i click on '...' to show more from omitted text and it doesn't expand visible text.
Attachments
Comments
Comment by Mads Kiilerich, on 2014-10-21 14:57
I doubt it was supposed to anything. It could make sense to hook it up to "increase diff context". That could be a nice feature if someone feel like implementing it.
Comment by Anatoly Belikov, on 2014-10-22 06:54
Yes, that's what i expected.
Comment by Andrej Shadura, on 2014-10-23 12:58
Comment by Andrej Shadura, on 2014-10-23 13:00
I'll try to play with this tonight, maybe I can implement it.
Comment by Andrej Shadura, on 2014-10-26 13:34
Here: not a very clean implementation, but it works. For now, for changeset pages only: 66795f1
@kiilerix, could you please review it?
Comment by Thomas De Schampheleire, on 2015-05-06 20:03
@andrew_shadura @kiilerix What is the status of this? I have the same expectation that clicking the ellipsis increases the diff context, at least between these lines...
Comment by Mads Kiilerich, on 2015-05-06 21:11
IIRC, the proposed change wasn't that clean.
Andrew is working on changing the 3 dots for other reasons - other changes in this area should wait for that.
It would be nice to have dynamic loading of diffs so we could load files separately and expand diff contexts dynamically. But that is a significant task.
For now, the best solution is to use the existing "Increase diff context". The 3 dots could perhaps be made the same link ... and the existing confusing up/down arrow could perhaps be removed. Sounds like an easy change.
Comment by Thomas De Schampheleire, on 2015-08-06 19:45
@andrew_shadura What is the status of this one?