Issue #39: Kallithea UI not usable on IE8

Reported by:	Philip Pemberton
State:	resolved
Created on:	2014-09-17 13:43
Updated on:	2014-09-24 17:53

Description

The Kallithea user interface doesn't work on Internet Explorer 8.

When opening a repository group which contains repos, Kallithea reports that there are no repositories present ("... with 0 repositories"). IE reports an error rendering the page:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; xs-KyMjLKskFwI;wKgCg5; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)
Timestamp: Wed, 17 Sep 2014 13:41:33 UTC
Message: 'undefined' is null or not an object
Line: 17
Char: 197697
Code: 0
URI: https://(redacted)/kallithea/js/yui.2.9.js?ver=0.1

These posts on the YUI forum:

http://yuilibrary.com/forum-archive/forum/viewtopic.php@f=90&t=8963.html

http://yuilibrary.com/forum-archive/forum/viewtopic.php@f=90&t=5015.html

Suggest that the issue may be an object which contains a trailing comma. Indeed, there are several of these in the page source.

Repo groups display fine.

Interestingly, when this happens, parts of the Kallithea UI revert to having a blue background (e.g. the menus). If you directly access a repo page, this also happens but with a different error:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; xs-KyMjLKskFwI;wKgCg5; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)
Timestamp: Wed, 17 Sep 2014 13:51:59 UTC


Message: Object doesn't support this property or method
Line: 1026
Char: 5
Code: 0
URI: https://(redacted)/kallithea/temp

Line 1026 is:

--->    $('#lang_stats').appendChild(tbl);
    $('#code_status_show_more').click(function(){
        $('.stats_hidden').show();
        $('#code_status_show_more').hide();
    });

Attachments

Comments

Comment by Philip Pemberton, on 2014-09-17 13:44

Comment by Philip Pemberton, on 2014-09-17 13:53

Comment by Mads Kiilerich, on 2014-09-17 13:57

We would like to support IE8 or later, but none of the main contributors use IE. Proper support for IE8 depends on the people who care.

Please contribute patches for fixing the issues you find ... or if it just is a trailing comma, the exact locations of them.

Comment by Mads Kiilerich, on 2014-09-17 13:59

Do you also see the issue on https://kallithea-scm.org/repos/mirror ?

Comment by Philip Pemberton, on 2014-09-17 17:05

Comment by Philip Pemberton, on 2014-09-17 17:08

Now I've fixed the description (now I have access to a browser which Bitbucket will work with ;) )

On the page you linked, there are several instances of the trailing comma. In "var TRANSLATION_MAP" (line 57), myDataSource.responseSchema.fields (line 439), myColumnDefs (line 473) and myDataTable (line 484).

Comment by Mads Kiilerich, on 2014-09-18 08:12

Please test https://bitbucket.org/kiilerix/kallithea/commits/9faa614b8d7e82e24e239bbb183546c7aabb7cfe and report any problems you see.

Comment by Mads Kiilerich, on 2014-09-24 17:53

Fix pushed.

Kallithea issues archive