Kallithea issues archive

Issue #366: Cannot approve pull request from fork

Reported by: Przemysław Marciniak
State: closed
Created on: 2020-03-11 14:20
Updated on: 2020-05-07 14:08


Could anyone provide proper workflow for pull request on kallithea which I am testing right now. I have just created simple repo with 1 file and I made 1 fork where I changed something and create pull request from fork to original repo. I have added reviewer and i add comment with approve field there. After that I cannot see any changes on original repo. I cannot see any other option to do that. Could you please help with this workflow. Please write if you need any details



Comment by Thomas De Schampheleire, on 2020-03-11 15:36

There is no automatic ‘merge’ workflow supported in Kallithea by default. The approval of a PR is not coupled to an automatic action. The owner of the repo can pull the changes, and merge/push them in their local repo, then push the changes to Kallithea.

Comment by Mads Kiilerich, on 2020-03-11 16:45

It would be quiet easy to implement a “merge” button. The real complexity for having it upstream is in supporting different approval policies and workflows. It would be bad to just have one workflow and insist on everybody using that. It would have to be very customizable.