Issue #356: Fix for Options fork icon
| Reported by: | Ross Thomas |
| State: | resolved |
| Created on: | 2020-02-06 00:30 |
| Updated on: | 2020-03-01 21:05 |
Description
A minor fix for the fork icon in the repo Options menu.
Q: With the demise of hg on BB how will we submit PR’s, etc. in the future?
Attachments
Comments
Comment by Mads Kiilerich, on 2020-02-06 01:29
Thanks for the patch. Which email address can we use for attribution?
We might have to create/recommend an alternative way of submitting patches. But as before, it is fine to send patches to the mailing list, or to host them on your own server somewhere.
Comment by Ross Thomas, on 2020-02-07 00:01
I don’t personally feel a burning need for attribution for a one-word patch. 
But if you need it for CC/FOSS compliance then it is: ross at lns-nevasoft dot com
Comment by Mads Kiilerich, on 2020-02-07 00:12
I can also just commit it. But without a unique identifier (email address) it is not really feasible to accept you as copyright holder of Kallithea.
Note that this will put your email address in clear text in the repo and on internet, bypassing your careful slight obfuscation here. Is that ok?
Comment by Ross Thomas, on 2020-02-07 00:27
As I say, I would feel silly getting attribution for a one-word patch. So you may as well go ahead and commit it.
Future submissions would be changeset exports/PR’s which would then have my email as part of the meta-data, at which point I’m ‘committed’
Comment by Mads Kiilerich, on 2020-02-07 00:36
That totally makes sense. I just wanted to make sure we did it in a way you also consider correct.
Thanks.
Comment by Thomas De Schampheleire, on 2020-03-01 21:05
Fixed with commit b495947ac174, thanks for submitting a patch!