Kallithea issues archive

Issue #344: 'Ignore whitespace' button on a file block inside a changeset does not work

Reported by: Thomas De Schampheleire
State: new
Created on: 2019-05-16 19:20
Updated on: 2019-05-23 09:40


When viewing a changeset, there is a global ‘Ignore whitespace’ button which causes the ‘ignorews=1' GET parameter, and which works correctly.

There is also a ‘Ignore whitespace’ button on each file block, which causes a ‘WS:1’ flag in the URL. This option does not have any influence on the diff.

Looking in the code, it looks as if the raw diff is obtained once for the changeset, taking into account the global ‘ignorews’ option, and then later split into file blocks (but without being able to influence the whitespace-ignoring part anymore.



Comment by Mads Kiilerich, on 2019-05-23 09:40

It also seems conceptually confusing to have many options for the same thing on the same page. It should perhaps just be global.

There could be a good use case for only showing some files / chunks or load on demand. But still, the diff options should probably still be for the whole page and apply to everything that is shown.