Issue #326: SQLAlchemy upgrade required
Reported by: | 刘科彬 |
State: | resolved |
Created on: | 2018-07-23 05:36 |
Updated on: | 2018-07-24 03:40 |
Description
MySQL 7
Warning: '@@tx_isolation' is deprecated and will be removed in a future release. Please use '@@transaction_isolation' instead
Attachments
Comments
Comment by Thomas De Schampheleire, on 2018-07-23 20:25
Hello, welcome to Kallithea and thanks for reporting.
The issue seems to be that sqlalchemy is using a construct 'tx_isolation' which recent versions MySQL is warning about. Later versions of SQLAlchemy have solved this problem with a version check. The minimum version you need of SQLAlchemy is 1.1.15 (see http://docs.sqlalchemy.org/en/latest/changelog/changelog_11.html#change-364804fd47128c29140cfd2c6f8b8063)
On the default branch of Kallithea, the version of SQLAlchemy is already more recent and turned into a range rather than a fixed version:
"SQLAlchemy>=1.1,<1.2",
compared to the version in the latest release ('stable' branch of Kallithea):
"SQLAlchemy==0.7.10",
I checked and the relevant commits that changed this line do not indicate other required code changes to support this newer SQLAlchemy version. You should thus be able to change setup.py manually and upgrade SQLAlchemy. These relevant commits are:
- 3c4b6ddf673551659b784dcba037aa05b8061824
- 1a080d4e926e6f9d0862123a2e8fef261709875d
- 3ed43530d3b859217299f2591a5efb39592fd17b
So, your options are:
- ignore the warning for now, everything still works fine
- manually upgrade sqlalchemy to 1.1.15 or a more recent version in 1.1.x range
- upgrade to the default branch of Kallithea, which is going to become a new major release in the future. For the 'stable' branch, we are not planning new releases to fix this issue.
Comment by 刘科彬, on 2018-07-24 03:38
@patrickdepinguin Thanks.
Comment by 刘科彬, on 2018-07-24 03:40
It is fixes on default
branch.