Issue #309: Simplify kallithea.tests.vcs by avoiding unnecessary metaprogramming constructs
| Reported by: | Branko Majic |
| State: | resolved |
| Created on: | 2018-02-10 22:56 |
| Updated on: | 2018-05-18 19:32 |
Description
Current test implementation in kallithea.tests.vcs module uses a number of metaprogramming constructs which possibly introduce more complexity than necessary.
For example, a number of test classes are instantiated by using globals and type construct.
It would be simpler to use plain inheritance instead, if possible - this would still allow for code de-duplication, but would make it clearer without digging into the code on what tests will be run.
Attachments
Comments
Comment by Thomas De Schampheleire, on 2018-05-18 19:32
Fixed with commit 45a281a0f36f