Issue #303: paster setup-db fails when git is not installed
Reported by: | Int |
State: | resolved |
Created on: | 2018-01-20 17:32 |
Updated on: | 2018-01-21 13:48 |
Description
I followed the instructions from https://kallithea.readthedocs.io/en/latest/installation_win.html
Step 9 – Configuring Kallithea says: "If you decided not to install git, you will get errors about it that you can ignore."
==> That is wrong. When git is not installed paster setup-db fails with fatal error - you can not ignore it.
You have to modify __init__.py
to get paster setup-db to run without having git installed.
Please correct the instuctions and add link to https://pythonhosted.org/Kallithea/usage/vcs_support.html
where is described how to modify __init__.py
Attachments
Comments
Comment by Thomas De Schampheleire, on 2018-01-20 20:24
While this is certainly confusing, I think your analysis may be incorrect: the error about the absence of git is indeed a warning. At least on my side, Kallithea is fully functional if I follow these installation steps without git.
The confusing thing is though that the warning is also the last thing that the setup-db script prints. I assume that this is the reason why you concluded that it is fatal.
Can you check that Kallithea indeed works fine for you, even when git is absent?
Comment by Mads Kiilerich, on 2018-01-20 23:38
Comment by Int, on 2018-01-21 08:14
You are right. Since the message about git is the last message I thought the setup process aborted with that error. But the database is created and works fine, even when git is absent.
Perhaps you could add a message like "database successfully created" at the end to prevent that confusion in the future?
Comment by Thomas De Schampheleire, on 2018-01-21 13:47
Thanks, sent pull request to add such message: https://bitbucket.org/conservancy/kallithea/pull-requests/370/setup-db-print-completion-message-to-avoid/diff
Comment by Thomas De Schampheleire, on 2018-01-21 13:48
Closing as problem is clear and clarification fix is sent.