Issue #280: Empty table of additional changes on PR created from range of changesets
| Reported by: | Łukasz Michalski |
| State: | resolved |
| Created on: | 2017-05-31 11:51 |
| Updated on: | 2018-06-10 18:36 |
Description
I use mercurial repository and kallithea 0.3.2
- Created PR from range of changesets using ChangeLog.
- Commited new changeset.
- Opened my PR and I see:
On the right side there is a part of button. When I click it nothing happens.
Regards, Łukasz
Attachments
Comments
Comment by Łukasz Michalski, on 2017-05-31 11:51
Comment by Mads Kiilerich, on 2017-06-01 00:39
Can you "view sources" in the browser and search for "This pull request can be updated" and see what html causes the partial button?
Comment by Łukasz Michalski, on 2017-06-01 06:47
This is an empty table with 2-3px height. What I tried to click was a small scrollbar:
Comment by Mads Kiilerich, on 2017-07-05 00:14
Right.
What would you expect it should show?
Normal pull requests are created at the end of branches and they end up being merged and thus no longer having anything for updating.
Ranges are however in the middle of history and will not be merged. They might have a huge amount of changesets available for update already from the beginning and it will never go away. Thus, it doesn't make sense to try to make ranges update-able. The bug is that that it shows the empty list. Do you agree?
Comment by Łukasz Michalski, on 2017-07-14 08:02
Yes, I agree.
Comment by Thomas De Schampheleire, on 2018-01-20 20:59
FYI, this problem is still present on the default branch.
Comment by Thomas De Schampheleire, on 2018-01-20 21:00
Comment by Thomas De Schampheleire, on 2018-05-19 20:00
Comment by Thomas De Schampheleire, on 2018-06-10 18:36
Fixed with commit abaf8e1033a6