Kallithea issues archive

Issue #278: cleanup .ini file generation

Reported by: domruf
State: new
Created on: 2017-05-12 08:49
Updated on: 2017-06-13 22:35

Description

There are currently to ways to generate .ini files: gearbox make-config and generate-ini.py

The goal should be to only have one.

Also, maybe test.ini should be generated on the fly. And development.ini should be removed and generated by the user instead.

Attachments

Comments

Comment by Thomas De Schampheleire, on 2017-06-13 19:34

I assume you are talking about the handling code itself, right? As the purpose of both scripts are different: make-config is the user-facing command to create a basic ini file from the template. The script does not make any real changes. 'generate-ini.py' is a developer script to regenerate the version-controlled scripts based on the template and some rules that define the differences between e.g development.ini and test.ini.

Comment by Mads Kiilerich, on 2017-06-13 22:35

Yes, but we could perhaps use make-config to generate development.ini and test.ini.

Or we could drop both of these .ini files. People could create their own development.ini with make-config. test.ini could be generated when running the tests. By writing a test.ini with the right sqlalchemy.url, we wouldn't need a TEST_DB hack in the git hooks.