Issue #276: convert tests.vcs to py.test
| Reported by: | domruf |
| State: | resolved |
| Created on: | 2017-05-10 11:06 |
| Updated on: | 2018-05-13 19:32 |
Description
Currently the test.vcs tests are still unittest style tests.
@patrickdepinguin is there a reason why they have not been converted?
Attachments
Comments
Comment by domruf, on 2017-05-11 13:50
Comment by Mads Kiilerich, on 2017-05-12 00:23
I guess the reason simply is that noone have done it yet. I guess anyone could do it ... and that while it perhaps it not directly would remove technical debt, it would move us forward and be very nice. It seems a bit unfair to assign that to Thomas.
Comment by domruf, on 2017-05-12 05:19
I assigned it to Thomas because he did the pytest migration.
Comment by Thomas De Schampheleire, on 2017-05-12 08:13
During the pytest migration, all tests that were using one of our own base classes (TestController or BaseTestSomething) were migrated. The VCS tests did not do that and use unittest directly. I did not spend the additional effort to align them: the real purpose was to step away from nose and use pytest -- the vcs tests worked before and after just as well.
While I agree that it would be nice to convert them, I do not have the time for that at the moment. As @kiilerix said, It is a generic improvement that could be tackled by everyone, hence I'm removing myself as Assignee.
Comment by Thomas De Schampheleire, on 2017-05-12 08:13
Comment by domruf, on 2017-05-12 08:48
@kiilerix can you give me permissions so I can assign this to myself?
Comment by Mads Kiilerich, on 2017-05-12 15:26
The bitbucket issue tracker doesn't seem to have sufficiently fine grained access control to allow that.
The issue tracker churn is quite low, so I suggest keeping it simple and just add a comment that you are working on it.
Comment by Branko Majic, on 2018-01-30 14:38
If noone is actually working on this one, it could be a nice low-hanging fruit that I would be interested into tackling. So - want me to look into it?
Comment by domruf, on 2018-01-30 17:16
@redpenguin I'm not working on this at the moment (priorities changed). So I say go ahead.
Comment by Branko Majic, on 2018-01-31 10:14
Ok, I'll start looking into this.
Comment by Thomas De Schampheleire, on 2018-05-13 19:32
Changes have been done by Branko Majic.