Kallithea issues archive

Issue #274: Regression: pullrequest GUI is broken after commits to PR head

Reported by: Konstantin Veretennicov
State: resolved
Created on: 2017-04-29 17:35
Updated on: 2017-05-13 01:06

Description

Steps to reproduce:

  1. Clean install Kallithea (on Windows, from sources, revision a1f8bf0)
  2. Create 2 users
  3. Create a repo with some commits
  4. Fork the repo and push a changeset to the fork
  5. Create a fork->master PR, containing one changeset; PR looks good for all users
  6. Push one more changeset to the fork
  7. Refresh PR for both users

Expected: "Next iteration" to show the new changeset, bottom comment box with colored balls to work as always - for all users.

Actual: nobody, except PR creator (or owner?), has the bottom comment box.

There is a JS error in browser console, see attachment.

Attachments

bug-chrome.png

bug-ff.png

Comments

Comment by Konstantin Veretennicov, on 2017-04-30 18:21

Confirmed on Ubuntu.

This is fixed by reverting 16234f629cfb (graph.js change).

Comment by domruf, on 2017-05-02 11:15

can you confirm that https://bitbucket.org/domruf/kallithea/commits/c6175ac2deb6951c1a5bcc0ca22c7ff4479db630 fixes the problem?

Comment by domruf, on 2017-05-02 11:51

@kiilerix can you give me privileges to assign issues to me?

Comment by Mads Kiilerich, on 2017-05-13 01:06

Fixed in 5258b66bf5d7