Kallithea issues archive

Issue #271: [feature] Updating instead of creating a new Pull Request

Reported by: Joey Novak
State: new
Created on: 2017-03-15 20:53
Updated on: 2018-05-18 20:01


When I use bitbucket with git. I'm pretty sure PRs automatically get updated as people make changes to the branches in question.

Kallithea doesn't seem to support this, rather, you can only create a new pr, in which case you lose all the comments. Is there a reason Kallithea can't either preserve comments for the new PR or allow updating of a PR?



Comment by Mads Kiilerich, on 2017-03-15 21:42

It is mostly by design that Kallithea aim to preserve the full context of all comments. I very much don't like how bitbucket comments on modified lines are so hard to find. But Kallithea (and perhaps bitbucket?) would like to work torwards using 'annotate' to put comments on the changeset that changed a line ... and let the PR show all the comments that apply the changeset in the PR. (That would however not directly cover the case of rebased changesets ...)

Comment by Andrej Shadura, on 2017-03-15 23:19

Comment by Eivind Tagseth, on 2017-03-16 08:21

Updating pull requests is only supported for mercurial, then you get a list of new changesets on the pull request branch, and a button to create a new revision of the pull request. I'd really like to have this function available for git as well, I may be creating a pull request in the near future.

Still, you lose all the old comments (but at least you get a link to the old revision of the pull request).

I guess the comments that are linked to a certain line is hard to keep, as that line may have been changed or removed with the update. I don't see why the general pull request comments cannot be kept though. Very often, the reason why you update a pull request is a comment, so it makes a lot of sense to be able to respond to it with the update.

Comment by Andrej Shadura, on 2017-03-16 08:40

If you wish to work on Git PRs, please do. I tried to do some preparatory work, but haven't found time to finish it, see http://patchwork.kallithea-scm.org/patch/2/

Comment by Thomas De Schampheleire, on 2018-05-18 20:01