Kallithea issues archive

Issue #270: [feature] specify the reviewer using the user group.

Reported by: shin
State: new
Created on: 2017-03-02 02:46
Updated on: 2018-05-18 20:02


I have a little trouble, I hope to add a new function of kallithea.

I am using a pull request. As the number of reviewers increases, it is necessary to repeat adding many reviewers of the same pattern every review.

I hope that at review time, reviewers can be specified as a user group, not as individual accounts.

If it becomes possible, the time it takes to designate the reviewer can be greatly shortened.



Comment by Mads Kiilerich, on 2017-03-03 01:52

I agree something like this could be nice.

The next question would be how it should work. Should one of the reviewers be enough or must all approve? Who should get notifications? One or all ... or the active ones?

I think there are many different answers to that - no single solution fits everybody.

One solution (which I have opted for) is thus to customize the code. I made it so it fits the process in my organization ... but what worked for us is not something I would recommend for others.

Comment by shin, on 2017-03-03 03:00

The function that I want is to shorten the time and labor for each addition to be added individually. I think that everyone should receive notifications.

I just want to ease the registration work of the reviewer. For operation, I would like the same as when registering individually.

Comment by Konstantin Veretennicov, on 2017-03-06 16:50

@export, see if you find the changes in pull request #226 useful. It's a customization we use.

Comment by Andrej Shadura, on 2017-03-06 17:52

At Collabora, we use Phab for reviews, and it supports group reviewers. It has a meta-group called Reviewers, in which everyone who’s done at least one review (I think) is automagically added. The change is considered approved as long as it’s approved by at least one reviewer — or more, depending on a specific case: Phab marks changes with at least one approval as Accepted, but it’s up to the project maintainers to require more or not.

I think it’s useful to have the tool not mandate the policy. Kallithea doesn’t have to necessarily require all reviewers to accept the change. It can be a behaviour to select per-repository, so that we have ‘permissive’ reviews (at least one reviewer acknowledges) or ‘strict’ reviews (every reviewer is required to ack it).

Comment by shin, on 2017-03-07 02:35

@kveretennicov, Thanks for your pull request information. I will try it.

@kiilerix, @andrew_shadura, Thanks for comment. I think that kallithea has a firm policy.

Comment by shin, on 2017-03-07 05:58

Comment by shin, on 2017-03-07 06:00

Comment by Thomas De Schampheleire, on 2018-05-18 20:02