Issue #198: documentation for windows should mention to add c:\path\to\git\bin to PATH
| Reported by: | domruf |
| State: | resolved |
| Created on: | 2016-02-29 13:52 |
| Updated on: | 2018-05-19 18:52 |
Description
I added c:\path\to\git\cmd instead of c:\path\to\git\bin to PATH which caused test_archives.py to fail because gzip and bzip2 were not available.
Attachments
Comments
Comment by Thomas De Schampheleire, on 2016-02-29 14:09
Is this issue just a short-term reminder for yourself? Otherwise, since you already are contributing to Kallithea, I think it would be great if you could send a patch instead.
Comment by Mads Kiilerich, on 2016-02-29 14:28
I guess the real problem here is that the test assumes these tools are available ... and often they are not on Windows.
It is not obvious that taking them from the git porcelain is the right solution ... but it might be an ok pragmatic solution.
I guess there might be other such dependencies. The test suite should perhaps explicitly require a full msys environment for Windows testling like Mercurial does.
However, in this case, I guess it could be better to replace the requirement for these two tools with direct invocation of the corresponding Python module.
Comment by domruf, on 2016-03-01 18:37
Well it is not only the tests. In case of test_archives.py it is not the test itself that needs gzip. The git backend needs gzip.
I agree that it would be better to not depend on these command line tools (see #194).
But as a short term solution some words in the documentation would be good.
I'll write something and create a PR.
Comment by Thomas De Schampheleire, on 2018-05-19 18:52
Fixed with d9e6e489f171