Kallithea issues archive

Issue #194: use more dulwich instead of calling git command line

Reported by: domruf
State: open
Created on: 2016-02-15 15:49
Updated on: 2018-05-19 20:33


looking at #190 made me realize there are quite a few git command line calls

I don't understand why we do this. Isn't this what dulwich is for?



Comment by Mads Kiilerich, on 2016-02-15 16:59

I don't know. I guess it can make sense to use hand optimized and by-definition-correct C code for the most performance sensitive parts.

It could perhaps make sense to see what other Python based git http (and soon ssh) server solutions use and perhaps share some low level stuff. For example, we have kallithea/lib/middleware/pygrack.py - I don't know why ... or why we don't use it more.

Comment by domruf, on 2016-02-16 09:45

OK then I set this on hold until we know more about all this

Comment by Thomas De Schampheleire, on 2018-05-19 20:33

Removing 'on hold' to not hide the issue more than the others.