Kallithea issues archive

Issue #184: is the private repository flag really necessary?

Reported by: domruf
State: new
Created on: 2016-01-08 16:09
Updated on: 2016-01-10 23:33


Is there a difference between a private repository and a repository where the default permission is None?

If there is no difference I think we should get rid of it.

A 'special' flag implies that it has 'special' consequences. But if there is nothing 'special' except the lock symbol then it should be removed.



Comment by domruf, on 2016-01-08 16:10

Comment by Mads Kiilerich, on 2016-01-10 23:33

A private repository is one where default doesn't have and can't be assigned access.

Yes, it is redundant, but it is also a safety mechanism that can be convenient.

The whole 'default' user concept is very confusing. That should first be cleaned up / clarified.

We carry patches where 'default access' is described as 'public', and it is also only possible for global admin users to set the 'private' flag false. That is also not an elegant solution so I haven't upstreamed it.

TL;DR: I agree there is a problem but am not sure what the solution should be.