Kallithea issues archive

Issue #13: add more id attributes to html elements

Reported by: domruf
State: closed
Created on: 2014-07-29 21:43
Updated on: 2015-07-27 20:24

Description

On the todo list on https://bitbucket.org/conservancy/kallithea/wiki/Home are selenium tests. Without id attributes it can be quite hard to clearly identify html elements in selenium tests. So I suggest to add id attributes to all clickable elements and all form elements.

Attachments

Comments

Comment by Mads Kiilerich, on 2014-07-29 23:59

Sure.

Closely related tasks are removal of explicit styling in the templates and general cleanup of template structure and removal of cut'n'pastes.

Comment by Thomas De Schampheleire, on 2015-06-16 19:55

@domruf @kiilerix Does it make sense to keep this issue open? When (If?) someone starts tackling a selenium test suite, any code changes required for that can be done then. To me, tracking an issue for it is not necessary.

Comment by Mads Kiilerich, on 2015-06-16 22:37

FWIW: I will probably not care much about this until I for some other reason start caring. If others find value in having it listed here, then fine with me.

Comment by Thomas De Schampheleire, on 2015-07-27 20:24

No need to keep an issue open for such a broad topic. When/if implementing Selenium tests, the necessary code changes to support it need to be made.