Issue #105: comment handling / e-mail: link to specific comments only works when page is already loaded
| Reported by: | Thomas De Schampheleire |
| State: | closed |
| Created on: | 2015-03-04 09:43 |
| Updated on: | 2015-06-12 09:16 |
Description
Scenario: - receive a mail about a pull request comment - click on the link that points to the pullrequest#comment-xxx
The pullrequest will open, but your browser (at least Firefox) will not jump to the comment. Once the page is loaded, you can reload the URL and then you jump correctly.
I assume this is because the comments are loaded dynamically, and the anchor is not yet available when the browser wants to jump, but I'm not sure.
Attachments
Comments
Comment by Jan Heylen, on 2015-03-04 13:18
I believe this page describes the issue and a possible set of solutions: http://blog.onthewings.net/2009/04/08/deep-linking-for-ajax/
Comment by Mads Kiilerich, on 2015-03-06 16:47
9dfd9d242728 was supposed to fix that ... and it works for me.
I have only seen it fail when I had javascript errors that prevented the browser from reaching that code?
Comment by Mads Kiilerich, on 2015-03-06 17:33
Hmm ... perhaps something just changed in the latest firefox version?
Comment by Thomas De Schampheleire, on 2015-06-12 09:16
Issue seems fixed now, closing.
Comment by Thomas De Schampheleire, on 2015-06-12 09:16
Fixed in current master.