Issue #102: 'my pull requests' when not logged in: incorrect handling of login
| Reported by: | Thomas De Schampheleire |
| State: | resolved |
| Created on: | 2015-02-21 19:58 |
| Updated on: | 2015-02-26 22:58 |
Description
Bug scenario:
- log out
- browse to 'my pull requests'
- you'll be presented with a page that is almost entirely dimmed, with a login screen (also dimmed). This page also repeats the top banner a second time.
- type credentials and login
- you are now forwarded to a partial page (/my_pullrequests_data), without top banner nor css, which thus displays incorrectly.
Attachments
Comments
Comment by Thomas De Schampheleire, on 2015-02-21 19:59
Comment by Thomas De Schampheleire, on 2015-02-21 20:01
Comment by mirrorbot, on 2015-02-26 22:58
my pullrequests: line up controller/template handling with repo pullrequests
Currently, the data for 'my pullrequests' is loaded dynamically through ajax, unlike the way 'repository pullrequests' are loaded (statically).
As there is no good reason to have both treated differently, and as dynamic loading of 'my pullrequests' is not really needed, rework the handling of the 'my pullrequests' page with the 'repository pullrequests' page.
This includes lining up the 'show closed pull requests' checkbox/link.
This also fixes issue #102 ('my pull requests' when not logged in:
incorrect handling of login).
→ <<cset e79993216c66>>